Skip to content

Fix local SDK guest bootstrap build path#4

Merged
spozitivom merged 2 commits into
masterfrom
codex/sdk-guest-bootstrap-env-fixes
Apr 1, 2026
Merged

Fix local SDK guest bootstrap build path#4
spozitivom merged 2 commits into
masterfrom
codex/sdk-guest-bootstrap-env-fixes

Conversation

@spozitivom

@spozitivom spozitivom commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR fixes the clean-checkout CI regressions introduced around the facade guest SDK bootstrap work.

The guest integration scope itself is unchanged:

  • guest APIs remain facade-specific
  • no generic chain abstraction redesign was added
  • no frontend or holdem changes are included here

What changed

  • synchronized the root package-lock.json with the actual workspace list
  • removed stale sdk-sui lockfile workspace/dependency state
  • replaced broken package-level config placeholder behavior for the active workspace packages
  • fixed Linux CI portability for build-critical package config files that were still tracked as git symlink entries instead of normal files
  • kept the sdk-facade guest bridge thin and unchanged in scope

Root cause

The PR originally failed in GitHub Actions at:

npm run build --prefix ./packages/borsh

The underlying problem was not the guest wrapper itself.

Two clean-environment issues were involved:

the root package-lock.json was stale relative to package.json
several package-level config files were still tracked as git symlink entries

This was masked on local Windows checkouts, where those files could appear usable, but it broke in clean Linux CI checkouts.

Verified

After this update, the PR no longer fails at the package build bootstrap stage:

Install Dependencies passes
Build borsh passes
Build SDK Core passes
Remaining CI status

The workflow still fails in the Check step, but that is now aligned with the existing repository state on master.

This PR has removed the PR-specific clean-checkout regression.
The remaining red status is the pre-existing repo-wide test failure already present on master, not a new failure introduced by the guest SDK changes.

Scope kept intentionally small

This PR does not:

redesign SDK architecture
add wallet-linking
add progression/rating
expand guest concepts beyond sdk-facade
attempt to repair unrelated legacy test failures already affecting master

@spozitivom spozitivom force-pushed the codex/sdk-guest-bootstrap-env-fixes branch from 9b0f8df to f795f7e Compare April 1, 2026 19:10
@spozitivom spozitivom merged commit 06916dc into master Apr 1, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant